test: Fixed runners not running 'board' integration test #2381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessio-perugini
approved these changes
Oct 20, 2023
umbynos
approved these changes
Oct 23, 2023
|
Before merging this, we must fix the failing test. |
cmaglie
force-pushed
the
fix_integr_test_runner
branch
from
589266c to
2b8d1be
Compare
cmaglie
added
topic: infrastructure
cmaglie
force-pushed
the
fix_integr_test_runner
branch
from
2b8d1be to
7231626
Compare
cmaglie
force-pushed
the
fix_integr_test_runner
branch
from
7231626 to
68be030
Compare
<<< Run completed (err = <nil>)
environment.go:52:
Error Trace: D:/a/arduino-cli/arduino-cli/internal/integrationtest/environment.go:52
D:/a/arduino-cli/arduino-cli/internal/integrationtest/environment.go:63
D:/a/arduino-cli/arduino-cli/internal/integrationtest/environment.go:63
D:/a/arduino-cli/arduino-cli/internal/integrationtest/environment.go:69
D:/a/arduino-cli/arduino-cli/internal/integrationtest/board/board_test.go:638
Error: Received unexpected error:
remove C:\Users\runneradmin\AppData\Local\Temp\cli2634248494\A\inventory.yaml: The process cannot access the file because it is being used by another process.
Test: TestCLIStartupWithCorruptedInventory
--- FAIL: TestCLIStartupWithCorruptedInventory (8.45s)
cmaglie
force-pushed
the
fix_integr_test_runner
branch
from
c23a84b to
7768115
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2381 +/- ##
==========================================
+ Coverage 65.16% 67.17% +2.00%
==========================================
Files 210 210
Lines 20519 20519
==========================================
+ Hits 13371 13783 +412
+ Misses 6024 5598 -426
- Partials 1124 1138 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
The
boardintegration test package was skipped during integration tests. This was due to a strange behavior ofjq, which was cutting the first package in the list unless the-nflag was passed.The documentation of jq reports:
¯\_(ツ)_/¯
What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change, and is titled accordingly?
Other information
See https://stackoverflow.com/a/68859958/1655275